Where params are union of types, merge the types instead of having numbered suffixes in type names #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniel-stripe
approved these changes
Jun 14, 2024
This was referenced Jul 17, 2024
This was referenced Jul 21, 2024
This was referenced Jul 27, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
PaymentIntentConfirmParams.mandate_datafromStripe.Emptyable<PaymentIntentConfirmParams.MandateData1 | PaymentIntentConfirmParams.MandateData2>toStripe.Emptyable<PaymentIntentConfirmParams.MandateData>where the new MandateData is a union of all the properties of MandateData1 and MandateData2PaymentMethodCreateParams.cardfromPaymentMethodCreateParams.Card1 | PaymentMethodCreateParams.Card2toPaymentMethodCreateParams.Cardwhere the new Card is a union of all the properties of Card1 and Card2SetupIntentConfirmParams.mandate_datafromStripe.Emptyable<SetupIntentConfirmParams.MandateData1 | SetupIntentConfirmParams.MandateData2>toStripe.Emptyable<SetupIntentConfirmParams.MandateData>where the new MandateData is a union of all the properties of MandateData1 and MandateData2