check hasOwnProperty when using for..in
#2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
a team and
helenye-stripe
and removed request for
a team
xavdid-stripe
commented
Jul 9, 2024
anniel-stripe
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using iterating over the properties of an object, we should be defensive and ensure we're only using the properties that belong directly to that object (not anything inherited from the prototype chain). If users have modified the base
Object, then we'll modify those modifications in a way we shouldn't, causing issues.This seemed like something we could catch in lint, and it is! We just disabled the rule for some reason. So I re-enabled it and fixed the errors.
More info: https://eslint.org/docs/latest/rules/guard-for-in
Fixes #2114
Fixes RUN_DEVSDK-1209