Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies versions #384

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Bump dependencies versions #384

merged 1 commit into from
Sep 12, 2017

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

While working on #383, I noticed that npm was complaining about some deprecated packages, so I thought I'd just bump all dependencies to their latest versions. Should probably have done this at the same time as #382, sorry!

I had to modify some tests to account for a breaking change in chai 4.x (cf. chaijs/chai#781).

@brandur-stripe
Copy link
Contributor

brandur-stripe commented Sep 12, 2017

Frankly surprised this went so smoothly :) The test suite in stripe-node is pretty good, so +1.

It looks like another one of your PRs that I just merged collided with package.json. Want to rebase?

@ob-stripe
Copy link
Contributor Author

Done!

@brandur-stripe brandur-stripe merged commit 467f05d into master Sep 12, 2017
@brandur-stripe brandur-stripe deleted the ob-bump-deps branch September 12, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants