Removed most instances of 'self' #615
Conversation
* Add lebab and a script to run it * lebab transform: arrow * lebab transform: arg-rest * lebab transform: arg-spread * lebab transform: obj-method * lebab transform: obj-shorthand * lebab transform: let * lebab transform: template * lebab transform: default-param * lebab transform: destruct-param * lebab transform: includes * Revert "Add lebab and a script to run it" This reverts commit 70fd492. * Revert "lebab transform: destruct-param" because its changes didn't seem good. This reverts commit b56f52d. * Revert "lebab transform: default-param" because it seems dangerous / backwards-incompatible. This reverts commit 7eba992. * Unrelated: mark 8.1 as minimum 8-series version * Add mocha-only script * Use arrows in more places * Loosen some eslint rules I don't love
|
Sorry, hope to look at this ~tomorrow... |
|
LGTM though if we can get that last one as an arrow function that'd be nice too |
rattrayalex-stripe
assigned paulasjes-stripe and unassigned ob-stripe and rattrayalex-stripe
|
@rattrayalex-stripe I was getting some weird errors with Nock when Should be ready for re-review now. |
|
@paulasjes-stripe Still seeing a What do you think about holding off on this until after 7.0.0 lands? Eg; shipping as part of 7.0.1. Feels like it may be a bit riskier, might be good to isolate it a bit from the other changes (some of which are also risky; would like to make it easier to debug should an issue arise). |
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
2 times, most recently
from
762b6a9 to
f780ff3
Compare
|
Per DM, we're going to hold off on this until 7.0.0 has been released and live for a few days. |
rattrayalex-stripe
force-pushed
the
v7.0.0
branch
2 times, most recently
from
9fdad65 to
cdea81a
Compare
|
Closing this as will be merging into master rather than the old |
Removed almost all cases of
const self = this;since we're (mostly) using arrow functions now.Notable exceptions are functions that are getting removed in #613 (e.g.
setMetadata) and functions which require the scope to be untouched (most of the Mocha test suite functions).Ran the tests in Node 6 and Node 8, leaning quite heavily on them here.
r? @rattrayalex-stripe @ob-stripe