GET and DELETE requests data: body->queryParams #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc? @rattrayalex-stripe @remi-stripe
Addresses #690 -- whenever an ApiResource method is called that corresponds to a GET or DELETE, those properties are attached to the end of the path.
I think this should be safe, assuming:
I also changed
mocha.opts
not to bail by default. Rationale: I couldn't find a way to override this from the command-line (but it's easy to add-b
if that's what you want), and I prefer not-bailing in cases where I need to make simple changes in many tests.