Add support for calculatedStatementDescriptor on Charge
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Apr 3, 2020
types/2020-03-02/index.d.ts
Outdated
| @@ -1,8 +1,7 @@ | |||
| ///<reference path='../lib.d.ts' /> | |||
| ///<reference path='../shared.d.ts' /> | |||
| ///<reference path='../Errors.d.ts' /> | |||
There was a problem hiding this comment.
This is a bug with codegen right?
remi-stripe
changed the title
calculatedStatementDescriptor on ChargecalculatedStatementDescriptor on Charge
remi-stripe
force-pushed
the
remi/codegen-afb5b18
branch
from
2bb6e2f to
8d40191
Compare
remi-stripe
changed the title
calculatedStatementDescriptor on ChargecalculatedStatementDescriptor on Charge
rattrayalex-stripe
approved these changes
Apr 3, 2020
| */ | ||
| pending_authorized_amount?: number; | ||
|
|
||
| /** | ||
| * The additional amount Stripe will hold if the authorization is approved. This field will only be non-zero during an `issuing.authorization.request` webhook. | ||
| * [DEPRECATED] The additional amount Stripe will hold if the authorization is approved. This field will only be non-zero during an `issuing_authorization.request` webhook. |
There was a problem hiding this comment.
Ideally we'd say what to do instead of the deprecated thing, but not a part of this PR.
| @@ -6116,7 +6116,7 @@ declare module 'stripe' { | |||
| status?: CardholderListParams.Status; | |||
|
|
|||
| /** | |||
| * Only return cardholders that have the given type. One of `individual`, `business_entity`, or `company`. | |||
| * Only return cardholders that have the given type. One of `individual` or `company`. | |||
There was a problem hiding this comment.
Just calling out that this docstring and the one above now disagree with the types. I think that's probably fine (just implies that business_entity is rare/unexpected, but possible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi afb5b18
r? @richardm-stripe @rattrayalex-stripe
cc @stripe/api-libraries