Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPDocs #1038

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Update PHPDocs #1038

merged 2 commits into from
Nov 9, 2020

Conversation

remi-stripe
Copy link
Contributor

Codegen for openapi 83680bb

r? @ctrudeau-stripe
cc @stripe/api-libraries

@@ -23,6 +23,9 @@
* returned on a request involving a PaymentIntent.
* @property PaymentMethod $payment_method The PaymentMethod object for errors
* returned on a request involving a PaymentMethod.
* @property string $payment_method_type If the error is specific to the type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also applies to other existing fields, but presumably this is nullable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the others are nullable too and it's because this one is not automatically generated but I'm tracking internally

@remi-stripe remi-stripe merged commit 13314f8 into master Nov 9, 2020
@remi-stripe remi-stripe deleted the remi/codegen-83680bb branch November 9, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants