Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for invalid keys in StripeClient #1054

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Improve error message for invalid keys in StripeClient #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/BaseStripeClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,10 @@ private function validateConfig($config)
// check absence of extra keys
$extraConfigKeys = \array_diff(\array_keys($config), \array_keys($this->getDefaultConfig()));
if (!empty($extraConfigKeys)) {
throw new \Stripe\Exception\InvalidArgumentException('Found unknown key(s) in configuration array: ' . \implode(',', $extraConfigKeys));
// Wrap in single quote to more easily catch trailing spaces errors
$invalidKeys = "'" . \implode("', '", $extraConfigKeys) . "'";

throw new \Stripe\Exception\InvalidArgumentException('Found unknown key(s) in configuration array: ' . $invalidKeys);
}
}
}
4 changes: 2 additions & 2 deletions tests/Stripe/BaseStripeClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ public function testCtorThrowsIfApiKeyIsUnexpectedType()
public function testCtorThrowsIfConfigArrayContainsUnexpectedKey()
{
$this->expectException(\Stripe\Exception\InvalidArgumentException::class);
$this->expectExceptionMessage('Found unknown key(s) in configuration array: foo');
$this->expectExceptionMessage('Found unknown key(s) in configuration array: \'foo\', \'foo2\'');

$client = new BaseStripeClient(['foo' => 'bar']);
$client = new BaseStripeClient(['foo' => 'bar', 'foo2' => 'bar2']);
}

public function testRequestWithClientApiKey()
Expand Down