Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Updates #1244

Merged
merged 1 commit into from
Feb 23, 2022
Merged

API Updates #1244

merged 1 commit into from
Feb 23, 2022

Conversation

yejia-stripe
Copy link
Contributor

Codegen for openapi 2775931.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for new values bbpos_wisepad3 and stripe_m2 on enum Terminal.Reader.device_type

@pakrym-stripe
Copy link
Contributor

Did we already ship the rest of SetupFutureUsage APIs in PHP?

@yejia-stripe
Copy link
Contributor Author

@pakrym-stripe No, I think this update is just a no-op for PHP because we don't generate all the individual fields of payment_method_options under PaymentIntent. Closing this PR

@pakrym-stripe
Copy link
Contributor

Doc updates still seem relevant. Why not merge it?

@yejia-stripe yejia-stripe deleted the latest-codegen branch February 23, 2022 16:06
@yejia-stripe yejia-stripe restored the latest-codegen branch February 23, 2022 16:08
@yejia-stripe
Copy link
Contributor Author

Ah sorry you're right, we should merge, but not release (based on previous updates). r? @dcr-stripe

@yejia-stripe yejia-stripe reopened this Feb 23, 2022
dcr-stripe
dcr-stripe approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - agreed we don't need to release this since it's effectively a no-op for PHP, but OK with merging.

@stripe-ci stripe-ci assigned yejia-stripe and unassigned dcr-stripe Feb 23, 2022
@yejia-stripe yejia-stripe merged commit aaade79 into master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcr-stripe dcr-stripe dcr-stripe approved these changes

Assignees

@yejia-stripe yejia-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yejia-stripe @pakrym-stripe @dcr-stripe