Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants for payment intent cancellation reasons #1526

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add constants for payment intent cancellation reasons #1526

merged 2 commits into from
Jul 19, 2023

Conversation

javespi
Copy link
Contributor

@javespi javespi commented Jul 11, 2023

Add the different values available for cancellation reason field when a payment intent is cancelled.

Values retrieved from API documentation:

Similar approach as it was already done for statuses:

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023

CLA assistant check
All committers have signed the CLA.

@richardm-stripe
Copy link
Contributor

Thanks for the contribution! I've fixed the underlying problem in our library generator, so this enum will be added once e2b090c#diff-5239e074340aff1a427e536f1944bba3ff00d356fafb24a988da1505c7236da7 is merged for our next release.

I'll merge your PR, even though it will get wiped by the generated version, so you get committer credit!

@richardm-stripe richardm-stripe merged commit 7648cf5 into stripe:master Jul 19, 2023
@javespi javespi deleted the add-cancellation-reasons-to-payment-intent branch July 21, 2023 07:23
@javespi
Copy link
Contributor Author

javespi commented Jul 21, 2023

Thank you @richardm-stripe for the effort! Which stack are you using for the library generator? I guess based on OpenAPI descriptions.

I'm curious about it; it would be worth to explore for some APIs I am currently developing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants