Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Discount, SourceTransaction and use sections in more places #1582

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Generate Discount, SourceTransaction and use sections in more places #1582

merged 2 commits into from
Sep 25, 2023

Conversation

pakrym-stripe
Copy link
Contributor

Auto generate Discount and SourceTransaction resources.

richardm-stripe
richardm-stripe approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM unless the Discount extends StripeObject -> Discount extends ApiResource was unintentional.

@pakrym-stripe pakrym-stripe merged commit 4a9474e into master Sep 25, 2023
21 checks passed
@remi-stripe remi-stripe deleted the pakrym/Generate_Discount__SourceTransaction_and_use_sections_in_more_places branch September 28, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardm-stripe richardm-stripe richardm-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pakrym-stripe @richardm-stripe