Add paginated requests helper function and use in Search and All #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
force-pushed
the
helenye-add-paginated-requests
branch
from
a05480c to
0640cb8
Compare
helenye-stripe
requested review from
a team,
richardm-stripe and
anniel-stripe
and removed request for
a team
|
Also assigning one additional person to gather more feedback on whether we want this or not! |
anniel-stripe
approved these changes
Jan 11, 2024
richardm-stripe
approved these changes
Jan 12, 2024
helenye-stripe
force-pushed
the
helenye-add-paginated-requests
branch
from
96fe563 to
863b876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purpose of de-magicking PHP search / all. This simplifies what the codegen will have to generate per resource (e.g. for search the body will just call the function _requestPage.)