Add support for listing source_transactions #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Source.php
Outdated
| $url = $this->instanceUrl() . '/source_transactions'; | ||
| list($response, $opts) = $this->_request('get', $url, $params, $options); | ||
| $this->refreshFrom($response, $opts); | ||
| return $this; |
There was a problem hiding this comment.
Is this supposed to mutate the source object?
There was a problem hiding this comment.
Oops! Absolutely not -- this endpoint returns a collection of source_transaction objects, not the source object itself. This is now fixed.
|
Nice OB! Left a comment on here. Can you also take a look at the test suite? |
ob-stripe
force-pushed
the
ob-source-transactions
branch
2 times, most recently
from
f30cd47 to
f4edc46
Compare
ob-stripe
force-pushed
the
ob-source-transactions
branch
from
f4edc46 to
979330e
Compare
|
I broke a few things after rebasing, but tests should be passing now! |
|
Thanks for the quick fixes! |
|
Released as 5.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @stan-stripe
Adds support for the
/v1/sources/src_.../source_transactionsendpoint.