Drop support for PHP 5.3 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2018
remi-stripe
reviewed
Jan 4, 2018
| @@ -60,6 +60,12 @@ Please see https://stripe.com/docs/api for up-to-date documentation. | |||
|
|
|||
| ## Legacy Version Support | |||
|
|
|||
| ### PHP 5.3 | |||
|
|
|||
| If you are using PHP 5.3, you can download v5.8.0 ([zip](https://github.com/stripe/stripe-php/archive/v5.8.0.zip), [tar.gz](https://github.com/stripe/stripe-php/archive/v5.8.0.tar.gz)) from our [releases page](https://github.com/stripe/stripe-php/releases). This version will continue to work with new versions of the Stripe API for all common uses. | |||
There was a problem hiding this comment.
Is it worth adding a scary blurb about how bad using this version (and 5.2) is?
| - STRIPE_MOCK_VERSION=0.5.0 | ||
| matrix: | ||
| - AUTOLOAD=1 | ||
| - AUTOLOAD=0 |
There was a problem hiding this comment.
Thanks for changing this whole thing back :)
|
LGTM. |
|
How about the short array syntax in PHP 5.4 ? |
|
@arcanedev-maroc Yep, that's on my TODO list too! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
This PR drops support for PHP 5.3, and gets rid of some now unneeded stuff.
Note that the destination branch is
integration-v6instead ofmasterso that we can merge all PRs going into stripe-php 6.0.0 and solve conflicts before merging intomaster.Fixes #406, although the fix won't be effective until we merge into
masterand actually release a new major version.