Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed namespaces in docblocks #455

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

weirdan
Copy link
Contributor

@weirdan weirdan commented Mar 1, 2018

Fixed a number of unqualified/wrongly qualified class references in
docblocks identified by static analysis.

Also fixed one param docblock that used number as a type (which is not
according to phpdoc docs).

Fixed a number of unqualified/wrongly qualified class references in
docblocks identified by static analysis.

Also fixed one param docblock that used `number` as a type (which is not
according to phpdoc docs).
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob-stripe
Copy link
Contributor

Thanks @weirdan!

@ob-stripe ob-stripe merged commit 7a22499 into stripe:master Mar 2, 2018
@ob-stripe
Copy link
Contributor

Released in 6.4.1. Thanks for the contribution @weirdan!

@weirdan weirdan deleted the dockblock-namespace-fixes branch March 2, 2018 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants