Adds support for 'partner_id' to 'setAppInfo' #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
suggested changes
Jun 28, 2018
lib/Stripe.php
Outdated
| @@ -199,12 +199,13 @@ public static function getAppInfo() | |||
| * @param string $appVersion The application's version | |||
| * @param string $appUrl The application's URL | |||
| */ | |||
| public static function setAppInfo($appName, $appVersion = null, $appUrl = null) | |||
| public static function setAppInfo($appName, $appPartnerId = null, $appUrl = null, $appVersion = null) | |||
There was a problem hiding this comment.
Unfortunately PHP doesn't support keyword arguments, so this is a breaking change. Mind setting $appPartnerId as the last argument?
Signed-off-by: zach wick <zwick@stripe.com>
zwick-stripe
force-pushed
the
zwick_partner_id_set_app_info
branch
from
5fbfc89 to
516c322
Compare
|
Reordered the positional arguments. ptal @ob-stripe |
ob-stripe
approved these changes
Jun 28, 2018
|
Released in 6.10.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for an optional partner_id attribute in the setAppInfo hash.