Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileUpload.php file to fix autoloading #534

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Adds a FileUpload.php file so that PSR-4 autoloading for the \Stripe\FileUpload class works correctly.

Fixes the issue reported by @ruudk in #520 (comment).

I can't think of a way to write automated tests for this, but I've verified manually that it works:

  • before the fix:
php > require("vendor/autoload.php");
php > echo class_exists('Stripe\FileUpload');
php > echo class_exists('Stripe\File');
1
php > echo class_exists('Stripe\FileUpload');
1
  • after the fix:
php > require("vendor/autoload.php");
php > echo class_exists('Stripe\FileUpload');
1

@brandur-stripe
Copy link
Contributor

Nice! I was following along on the thread, and it's great to have found a solution so quickly.

LGTM.

@ob-stripe
Copy link
Contributor Author

Thanks @brandur-stripe! All credit goes to @ruudk here :)

@ob-stripe ob-stripe merged commit fc93578 into master Oct 11, 2018
@ob-stripe ob-stripe deleted the ob-autoload-fileupload branch October 11, 2018 16:16
@ob-stripe
Copy link
Contributor Author

Released as 6.19.4.

@ruudk
Copy link
Contributor

ruudk commented Oct 11, 2018

Thanks for fixing it so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants