Add support for Radar List and ListItem resources #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep. We'll probably have to rename it to |
remi-stripe
force-pushed
the
remi-add-radar-lists
branch
from
38603ba to
52812b0
Compare
|
r? @ob-stripe |
ob-stripe
suggested changes
Nov 12, 2018
| { | ||
| const TEST_RESOURCE_ID = 'rsli_123'; | ||
|
|
||
| public function testIsValueListItemable() |
There was a problem hiding this comment.
Suggested change
| public function testIsValueListItemable() | |
| public function testIsListable() |
tests/Stripe/Radar/ValueListTest.php
Outdated
| { | ||
| const TEST_RESOURCE_ID = 'rsl_123'; | ||
|
|
||
| public function testIsValueListable() |
There was a problem hiding this comment.
Suggested change
| public function testIsValueListable() | |
| public function testIsListable() |
remi-stripe
force-pushed
the
remi-add-radar-lists
branch
from
52812b0 to
bd5e99b
Compare
|
Damn search and replace. Fixed, PTAL @ob-stripe |
ob-stripe
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries
cc @ob-stripe as
Listis forbidden as a class name in PHP soListas an object in Radar was likely a bad idea :p