Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPDocs in SubscriptionSchedule and SubscriptionScheduleRevision #599

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Fix PHPDocs in SubscriptionSchedule and SubscriptionScheduleRevision #599

merged 1 commit into from
Feb 16, 2019

Conversation

marotpam
Copy link
Contributor

The PHPDocs in SubscriptionSchedule and SubscriptionScheduleRevision were incorrectly setting their classes to Subscription. There was also a typo in the property chedule inside of SubscriptionScheduleRevision, which would've caused some issues when integrating with the API

remi-stripe
remi-stripe approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @marotpam!

@remi-stripe remi-stripe merged commit e495e82 into stripe:master Feb 16, 2019
@ob-stripe
Copy link
Contributor

Released as 6.30.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marotpam @ob-stripe @remi-stripe @stripe-ci