Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants for person.* events and constants #628

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

remi-stripe
Copy link
Contributor

Fixes #627

r? @ob-stripe
cc @stripe/api-libraries

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Apr 11, 2019
@virgofx
Copy link
Contributor

virgofx commented Apr 11, 2019

Can we add a few more constants for the same class .... see #627 (comment)

@remi-stripe
Copy link
Contributor Author

I'm working on it @virgofx

@remi-stripe remi-stripe changed the title Add constants for person.* events Add constants for person.* events and constants Apr 11, 2019
@remi-stripe
Copy link
Contributor Author

@ob-stripe Added constants for Account and Person. PTAL

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Apr 11, 2019
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Apr 12, 2019
@ob-stripe ob-stripe merged commit a5ae418 into master Apr 12, 2019
@ob-stripe ob-stripe deleted the remi-add-person-events branch April 12, 2019 17:08
@virgofx
Copy link
Contributor

virgofx commented Apr 12, 2019

Awesome, thanks so much !

@virgofx
Copy link
Contributor

virgofx commented Apr 12, 2019

Any way you guys can cut a new release with updated constants? This is very useful! Thx

/cc @ob-stripe

@ob-stripe
Copy link
Contributor

Released as 6.31.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Missing new Person Events "person.*"
4 participants