Update return type to static to improve static analysis
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @virgofx, thanks for the contribution! This looks peaceful to me. |
|
👍 Very minor and there were a few other areas in PHP docblock in the code that already use |
|
Released in 6.34.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there is no official PHPDoc standard ... Pretty much all static analyzers (phpstan, etc.) and leading IDEs (e.g. PHPStorm) all support the
@return static. Making this change will improve static analysis and prevent unnecessary docblock declarations to coerce the returned type into the class referenced from the static call.