Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Customer Balance Transaction resource and APIs #649

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Add support for Customer Balance Transaction resource and APIs #649

merged 1 commit into from
Jun 18, 2019

Conversation

remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch from a2459ee to 7ca602b Compare May 6, 2019 19:54
ob-stripe
ob-stripe suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, lgtm otherwise.

lib/CustomerBalanceTransaction.php Outdated Show resolved Hide resolved
lib/CustomerBalanceTransaction.php Outdated Show resolved Hide resolved
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe May 7, 2019
@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch from 7ca602b to b320263 Compare May 7, 2019 05:05
@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch from b320263 to 8c66747 Compare May 31, 2019 17:32
@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch from 8c66747 to 71e59c0 Compare May 31, 2019 20:44
ob-stripe
ob-stripe suggested changes May 31, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, but LGTM otherwise.

lib/Customer.php Outdated Show resolved Hide resolved
lib/Customer.php Outdated Show resolved Hide resolved
@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch from 71e59c0 to ed9d3c3 Compare May 31, 2019 22:43
@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch 2 times, most recently from c12b84d to cceccd4 Compare June 16, 2019 18:01
@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Jun 17, 2019
@remi-stripe
Copy link
Contributor Author

@ob-stripe forgot to re-assign that one, PTAL

ob-stripe
ob-stripe suggested changes Jun 17, 2019
View reviewed changes
lib/Customer.php Outdated Show resolved Hide resolved
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Jun 17, 2019
@remi-stripe remi-stripe force-pushed the remi-add-customer-balance-transactions branch from cceccd4 to 678788e Compare June 17, 2019 19:44
@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Jun 17, 2019
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Jun 17, 2019
@ob-stripe ob-stripe merged commit 43be670 into master Jun 18, 2019
@ob-stripe ob-stripe deleted the remi-add-customer-balance-transactions branch June 18, 2019 06:28
@ob-stripe
Copy link
Contributor

Released as 6.38.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remi-stripe @ob-stripe @stripe-ci