Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact API key in RequestOptions debug info #768

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Redact API key in RequestOptions debug info #768

merged 1 commit into from
Oct 18, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Redacts the API key in RequestOpts debug info (when using var_dump or print_r).

@ob-stripe ob-stripe mentioned this pull request Oct 18, 2019
Merged
remi-stripe
remi-stripe approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick but LGTM. Not sure how to confirm this works with var_dump too though

lib/Util/RequestOptions.php Outdated Show resolved Hide resolved
@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Oct 18, 2019
@ob-stripe
Copy link
Contributor Author

Not sure how to confirm this works with var_dump too though

You can't capture the output of var_dump so it's not possible to write an automated test for it. I think we'll just have to trust PHP's documentation here :)

@ob-stripe
Copy link
Contributor Author

ptal @remi-stripe

@ob-stripe ob-stripe assigned remi-stripe and unassigned ob-stripe Oct 18, 2019
remi-stripe
remi-stripe approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change and all the tests!

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Oct 18, 2019
@ob-stripe ob-stripe merged commit cb57873 into master Oct 18, 2019
@ob-stripe ob-stripe deleted the ob-redact-key branch October 18, 2019 17:19
@ob-stripe ob-stripe changed the title Redact API key in RequestOpts debug info Redact API key in RequestOptions debug info Oct 18, 2019
@ob-stripe
Copy link
Contributor Author

Released as 7.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ob-stripe @remi-stripe @stripe-ci