Use native_function_invocation rule #858
Conversation
| ->setRules([ | ||
| '@PHP56Migration:risky' => true, | ||
| '@PHPUnit57Migration:risky' => true, |
| $logger = new DefaultLogger(); | ||
| $logger->error("message"); | ||
| // DefaultLogger uses PHP's `error_log` function. In order to capture | ||
| // the output, we need to temporarily redirect it to a temporary file. |
There was a problem hiding this comment.
I had to completely rewrite this test, as previously it was using a hack where we manually defined an error_log() function in the \Stripe\Util namespace and relied on the fact that DefaultLogger called error_log() in its non-qualified form.
The new test actually captures the output of PHP's \error_log() function.
| } finally { | ||
| \ini_set('error_log', $origErrorLog); | ||
| \fclose($capture); | ||
| } |
There was a problem hiding this comment.
While running the test suite, I noticed that this test was printing "Stripe Notice: Undefined property of Stripe\StripeObject instance: nonexistent" to stdout. I used the same technique as DefaultLoggerTest to capture the output. This has two upsides: the test suite's output is clean, and we actually test the behavior that accessing a non-existent property outputs a notice to the logger.
|
Released as 7.23.0. |
r? @brandur-stripe @richardm-stripe
cc @stripe/api-libraries
Enables the
native_function_invocationrule.Replaces #806.