Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get closer to @PhpCsFixer standard ruleset #865

Merged
merged 97 commits into from
Feb 10, 2020
Merged

Get closer to @PhpCsFixer standard ruleset #865

merged 97 commits into from
Feb 10, 2020

Conversation

ob-stripe
Copy link
Contributor

r? @richardm-stripe @cjavilla-stripe
cc @stripe/api-libraries

This PR enables a lot PHP-CS-Fixer rules. The goal is to get as close as possible to the @PhpCsFixer standard ruleset, which enforces fairly opinionated style rules.

There are still a few rules that are not enabled, or are enabled with a custom configuration, because they cause too many changes in codegen'd files and I'd rather we generate compliant code in the first place instead of relying too heavily on PHP-CS-Fixer to reformat everything.

Once all those issues are fixed, we should be able to remove the long list of rules from .php_cs.dist and just enable the @PhpCsFixer ruleset instead.

I recommend reviewing the PR commit by commit. There are lot of commits, but most of them simply add a rule to .php_cs.dist and don't do anything else because we were already compliant with that rule.

@ob-stripe
Use array_indentation rule
99862a8
@ob-stripe
Use cast_spaces rule
3c2cd77
@ob-stripe
Use class_definition rule
38b4ab2
@ob-stripe
Use combine_consecutive_unsets rule
9a5e8c6
@ob-stripe
Use comment_to_phpdoc rule
4990b41
@ob-stripe
Use compact_nullable_typehint rule
6a8fd09
@ob-stripe
Use concat_space rule
dd332f4
@ob-stripe
Use declare_equal_normalize rule
6febfed
@ob-stripe
Use ereg_to_preg rule
6a34965
@ob-stripe
Use error_suppression rule
a1dd4ae
@ob-stripe
Use escape_implicit_backslashes rule
e3c9768
@ob-stripe
Use explicit_string_variable rule
dab9e29
@ob-stripe
Use final_internal_class rule
4dcfc31
@ob-stripe
Use fopen_flag_order rule
228d348
@ob-stripe
Use fopen_flags rule
9c95ad6
@ob-stripe
Use fully_qualified_strict_types rule
9a06631
@ob-stripe
Use function_to_constant rule
8339363
@ob-stripe
Use function_typehint_space rule
b6aac1d
@ob-stripe
Use heredoc_to_nowdoc rule
030772f
@ob-stripe
Use implode_call rule
99c9a20
@ob-stripe
Use increment_style rule
4528c66
@ob-stripe
Use is_null rule
e3410ff
@ob-stripe
Use logical_operators rule
b0394a2
@ob-stripe
Use lowercase_cast rule
3cdeae4
@ob-stripe
Use lowercase_static_reference rule
ca659ed
@ob-stripe
Use magic_constant_casing rule
25020bc
@ob-stripe
Use magic_method_casing rule
102075d
@ob-stripe
Use method_chaining_indentation rule
a274a36
@ob-stripe
Use modernize_types_casting rule
65f91c0
@ob-stripe
Use multiline_comment_opening_closing rule
fb437b3
@ob-stripe ob-stripe merged commit 9bb7ec1 into master Feb 10, 2020
@ob-stripe ob-stripe deleted the ob-more-phpcs branch February 10, 2020 20:55
@ob-stripe
Copy link
Contributor Author

Released as 7.24.0.

@ob-stripe ob-stripe mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ob-stripe @remi-stripe @stripe-ci @cjavilla-stripe @richardm-stripe