Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen nested resources #911

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Codegen nested resources #911

merged 1 commit into from
Apr 3, 2020

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Apr 3, 2020 •
edited
Loading

These are the remaining changes necessary to codegen the nested resources. All changes are ordering/docstring related other than

  • TYPE_ADJUSTEMENT is renamed to TYPE_ADJUSTMENT

r? @ob-stripe
cc @stripe/api-libraries

@richardm-stripe richardm-stripe changed the title Codegen nested resources Codegen nested resources in PHP Apr 3, 2020
@richardm-stripe richardm-stripe changed the title Codegen nested resources in PHP Codegen nested resources Apr 3, 2020
ob-stripe
ob-stripe approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richardm-stripe richardm-stripe merged commit 151c6b7 into master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardm-stripe @ob-stripe @stripe-ci