Services bugfix: convert nested null params to empty strings #933
Conversation
richardm-stripe
force-pushed
the
richardm-recursive-formatparams
branch
from
d583711 to
d5bda98
Compare
| static::assertTrue(null !== $result['foo']['bar']); | ||
| static::assertTrue(1 === $result['foo']['baz']); | ||
|
|
||
| $result = \Stripe\Service\AbstractService::formatParams(['foo' => ["bar", null, null, "baz"]]); |
There was a problem hiding this comment.
What about passing
[
'email' => null,
'invoice_settings' => [
'default_payment_method' => 'null',
],
]
As in, this method didn't seem recurring or able to handle non top-level params
There was a problem hiding this comment.
I don't quite follow -- this PR adds a recursive call https://github.com/stripe/stripe-php/pull/933/files#diff-d6b577df0148860a08e6dfb3025bd0d0R52
and this test case covers non top-level params -- everything is nested one level under "foo".
|
ptal @remi-stripe |
There was a problem hiding this comment.
Approving though I'd feel better if we waited for @ob-stripe's +1 to be safe
There was a problem hiding this comment.
LGTM, though I'd prefer not to make the method public. You can use \ReflectionMethod to invoke protected or private methods in tests (e.g. https://github.com/stripe/stripe-php/blob/master/tests/Stripe/StripeObjectTest.php#L28-L29). Feel free to leave as is though.
|
Thanks! Made private |
|
Formatting error is causing CI to fail, ptal @richardm-stripe |
|
Fixed, sorry
ptal @ob-stripe
…On Fri, May 15, 2020 at 1:26 PM Olivier Bellone ***@***.***> wrote:
Formatting error is causing CI to fail, ptal @richardm-stripe
<https://github.com/richardm-stripe>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMTZ7O3XDKDU6ATHRLL23YDRRV3LVANCNFSM4NBTPUCA>
.
|
richardm-stripe
changed the title
With PHP services, unlike the singlon API, sending
nullon a method's params is translated to an empty string when it is sent to the API, to cause the API to unset that field. This was only working properly for top-level parameters. This PR causes the substitution to take place recursively, and handle null properly inside arrays (both associative and non-associative).