feat: add dark google pay button option #1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for
pay_dark
andstandard_dark
to the<GooglePayButton />
component'stype
prop. This allows you to display the dark Google Pay button.This includes a breaking change.
This changes the
<GooglePayButton />
component behavior in that it no longer automatically uses the dark version when the device is in Dark Mode. Instead, merchants should detect Dark Mode in their app (part of react native core) and use the<GooglePayButton />
type
prop appropriately (according to Google's guidelines).This PR doesn't add any additional assets, it just moves assets from the
*-night
directories into the maindrawable
directories. Previously, the dark google pay buttons were only shown if the device was in dark mode. (see breaking change)Actually- this PR removes some unused assets 😄
Motivation
requested by users, Google will sometimes reject an app if the app isn't using the dark button when on a light background
Testing
Screen.Recording.2022-07-20.at.3.10.26.PM.mov
Documentation
Select one: