Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add call to action button label configuration to initPaymentSheet #1190

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

Allow merchants to customize the call to action button in payment sheet. This will also apply to apple pay once #1164 lands

This PR also upgrades to stripe-ios 23, which completes prework for splitting our SDK into smaller distinct modules.

Motivation

fixes #836

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 6fa419c into master Nov 2, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/paymentsheetcta branch November 2, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initPaymentSheet params accept payment button label
1 participant