fix: Upgrade android, fix breaking changes #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brentvatne
pushed a commit
to expo/expo
that referenced
this pull request
Feb 8, 2023
# Why fix expo go build error where kotlin 1.8 is incompatible with 1.6: https://github.com/expo/expo/actions/runs/4120016867/jobs/7114321156 # How - the underlying module of stripe 0.23.1 ships kotlin 1.8 which is prebuilt as aar/jar on maven central. we have no way to downgrade its kotlin version but only to upgrade kotlin in whole android expo go. - stripe 0.23.1 has a build error error and fixed at stripe/stripe-react-native#1289. upgrade the vendoring module to 0.23.3. # Test Plan versioned android expo go + ncl launch test # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
stripe-android 20.19.2 included some breaking code changes for Kotlin, and was picked up automatically due to soft version matching. this PR fixes those
Motivation
Closes #1288
Testing
Documentation
Select one: