Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fixes #1812 CardField onCardChange not triggering in React Native Stripe #1820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaushil111
Copy link

@kaushil111 kaushil111 commented Jan 27, 2025

Fixes #1812

Summary

  • Updated CardChangedEvent and CardFocusEvent to conform to the Fabric protocol
  • Updates the dispatcher in CardFieldView to fabric-compatible code
  • Checks the id of the view before dispatching the events in case the event is fired before the render is complete, thereby causing the id to be -1. This also leads to the following error

Maximum call stack size exceeded (native stack depth). No stack

Motivation

#1812

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

Copy link

cla-assistant bot commented Jan 27, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 27, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kaushil Ruparelia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

…ct Native Stripe

- Updated CardChangedEvent and CardFocusEvent to conform to the Fabric protocol
- Updates the dispatcher in CardFieldView to Fabric compatible code
- Checks the id of the view before dispatching the events in a case where the event is fired before the render is complete, thereby causing the id to be -1. This also leads to the following error
>  Maximum call stack size exceeded (native stack depth) No stack
@kaushil111
Copy link
Author

@charliecruzan-stripe let me know your thoughts on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Android] CardField onCardChange not triggering in React Native Stripe
1 participant