Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing 3ds button props #234

Merged
merged 3 commits into from
May 20, 2021
Merged

Conversation

arekkubaczkowski
Copy link
Collaborator

@arekkubaczkowski arekkubaczkowski commented May 19, 2021

resolves #201
resolves #182

@thorsten-stripe
Copy link
Contributor

@arekkubaczkowski can you post yyour threeDSecureParams object? I have

threeDSecureParams: {
            backgroundColor: '#800080', // iOS only
            timeout: 5,
            label: {
              headingTextColor: '#FFC0CB',
              headingFontSize: 13,
            },
            navigationBar: {
              headerText: '3d secure',
            },
            footer: {
              backgroundColor: '#800080', // iOS only
            },
            submitButton: {
              backgroundColor: '#800080',
              borderRadius: 12,
              textColor: '#FFC0CB',
              textFontSize: 14,
            },
          },

But it does not seem to work for the button

image
image

@arekkubaczkowski
Copy link
Collaborator Author

arekkubaczkowski commented May 20, 2021

@thorsten-stripe because for complete authentication button you have to set styles for continueButton, this is how it's named on native side also

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@arekkubaczkowski arekkubaczkowski merged commit e970e07 into master May 20, 2021
@arekkubaczkowski arekkubaczkowski deleted the fix/three-d-s-styling branch May 20, 2021 08:23
@benomatis
Copy link
Collaborator

@arekkubaczkowski can you still post your threeDSecureParams object please? Will the doc be updated? Would it not be practical if the doc actually had ALL options listed?

@arekkubaczkowski
Copy link
Collaborator Author

arekkubaczkowski commented May 20, 2021

@benomatis all of the properties are listed in API reference https://stripe.dev/stripe-react-native/api-reference/interfaces/threedsecureconfigurationparams.html
docs will be updated with the new release version, @thorsten-stripe am I right? I am not sure how GH pages are configured

@arekkubaczkowski
Copy link
Collaborator Author

@benomatis
Copy link
Collaborator

@arekkubaczkowski Thank you, we'll only need the doc to be updated then.

@benomatis
Copy link
Collaborator

@arekkubaczkowski This is now working great, thank you so much!

@benomatis
Copy link
Collaborator

@arekkubaczkowski I use dark mode on my phone, and it appears to make the bottom gray part (with Learn more... and Need help) to be really dark, like if there was an overlay above it, but it's not, if I tap it, it works fine, it's just very dark. Any way that could be overriden? Interestingly the very top gray line, just above the popup, remains the same gray. Shall I open a separate issue for this?

@arekkubaczkowski
Copy link
Collaborator Author

Shall I open a separate issue for this?

please do and provide some screenshots

@benomatis
Copy link
Collaborator

Shall I open a separate issue for this?

please do and provide some screenshots

ok, I will

@benomatis
Copy link
Collaborator

@arekkubaczkowski #248 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants