Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Multiline card element #415

Merged
merged 14 commits into from
Aug 3, 2021
Merged

WIP: Multiline card element #415

merged 14 commits into from
Aug 3, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

closes #83

@arekkubaczkowski arekkubaczkowski changed the title Multiline card element WIP: Multiline card element Jul 13, 2021
@arekkubaczkowski arekkubaczkowski mentioned this pull request Jul 15, 2021
Closed
thorsten-stripe
thorsten-stripe suggested changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

Also, I think the postalCode and billing address country of the cardform are not being submitted. PTAL. Same as with the cardfield the postalcode from the cardform should take priority for being set as billing postal code on the payment method.

example/src/screens/MultilineWebhookPaymentScreen.tsx Outdated Show resolved Hide resolved
example/src/screens/MultilineWebhookPaymentScreen.tsx Outdated Show resolved Hide resolved
example/src/screens/MultilineWebhookPaymentScreen.tsx Outdated Show resolved Hide resolved
android/src/main/java/com/reactnativestripesdk/CardFormViewManager.kt Outdated Show resolved Hide resolved
thorsten-stripe
thorsten-stripe suggested changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all props that don't work across platforms

src/components/CardForm.tsx Outdated Show resolved Hide resolved
src/components/CardForm.tsx Outdated Show resolved Hide resolved
thorsten-stripe
thorsten-stripe approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@arekkubaczkowski arekkubaczkowski merged commit fab6536 into master Aug 3, 2021
@arekkubaczkowski arekkubaczkowski deleted the feat/multiline-card-widget branch August 3, 2021 07:34
@thorsten-stripe thorsten-stripe mentioned this pull request Aug 3, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorsten-stripe thorsten-stripe thorsten-stripe approved these changes