-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote relations #32
Conversation
as well as helperified model creation for both
# Conflicts: # test/models.test.js # test/remote-connector.test.js # test/remote-models.test.js
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Its not actually supposed to pass currently... the 1 test that matters fails, not sure how or why or how to fix it but I will attempt.. and welcome any tips (: We really need this at the company I work at... |
I'm currently also looking into this bug, what I did for a experimental fix was to add the following code to the relations mixin (at https://github.com/strongloop/loopback-connector-remote/blob/master/lib/relations.js#L209)
it simply checks if the relation property function is being called without any parameters and returns the cached data if it is available. |
Hm ok awesome, I'm not either... I've actually got a current pull request open with a failing test to demonstrate the issue exactly... I'll run it with your fix see if the issue is resolved with this.. temporarily |
It seems the remote datasource connector does not allow
include: relation
I've written a few tests that currently show how it does not work... though I have yet to figure out how to fix it.
I was hoping it would show "failing tests" under the github status