[SEMVER-MAJOR] Always use bluebird as promise library #1896
Conversation
|
LGTM but @bajtos should confirm this one before you merge. Also, why so many fails on CI? |
bajtos
changed the title
| @@ -48,6 +48,3 @@ assert.isFunc = function(obj, name) { | |||
| assert(typeof obj[name] === 'function', name + ' is not a function'); | |||
| }; | |||
|
|
|||
| if (!('Promise' in global)) { | |||
There was a problem hiding this comment.
Please remove the trailing empty line at L50.
|
@jannyHou code changes LGTM. Please rebase your patch on top of the current master and add an entry to @superkhau could you please help here? |
| @@ -34,6 +34,7 @@ | |||
| "dependencies": { | |||
| "async": "^0.9.0", | |||
| "bcryptjs": "^2.1.0", | |||
| "bluebird": "^2.9.9", | |||
There was a problem hiding this comment.
Please use 3.x version - the same as we do in juggler (loopbackio/loopback-datasource-juggler#790)
There was a problem hiding this comment.
Didn't notice the older version of bluebird here. As suggested by @bajtos, please use 3.1.1 (latest on NPM - I checked for you).
"mostly good" would be a better description - we should upgrade to |
| } | ||
|
|
||
| var promise = new global.Promise(function(resolve, reject) { | ||
| var promise = new Promise(function(resolve, reject) { | ||
| cb = function(err, data) { | ||
| if (err) return reject(err); | ||
| return resolve(data); |
There was a problem hiding this comment.
I don't think the return is necessary here.
There was a problem hiding this comment.
It's fine to leave this since it's in the original code and not part of your changes anyways.
Sure. @jannyHou Ping me when you're working on this. |
jannyHou
force-pushed
the
feature/upgrade-to-bluebird
branch
2 times, most recently
from
8b48981 to
680317f
Compare
Replace `global.Promise` with `bluebird`
jannyHou
force-pushed
the
feature/upgrade-to-bluebird
branch
from
680317f to
889c561
Compare
[SEMVER-MAJOR] Always use bluebird as promise library
This pr is created for updating files to use
bluebirdas promise library.See details here:
Connect to strongloop-internal/scrum-loopback#615
Related: loopbackio/loopback-datasource-juggler#790