Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for new i915 params usage #65

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

zhtengw
Copy link
Contributor

@zhtengw zhtengw commented Apr 25, 2023

No description provided.

Copy link
Contributor

@pahowes pahowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is a core change (introduction of the i915.max_vfs parameter) is it worth bumping the next release to v6.2 to prevent confusion? It's a breaking change.

README.md Outdated
@@ -13,8 +13,8 @@ For Arch Linux users, it is available in AUR. [i915-sriov-dkms-git](https://aur.

Tested kernel versions:

* `pve-kernel-6.1.0-1-pve`~`6.1.10-1-pve` on PVE VM Host
* `gentoo-sources-6.1.0-gentoo`~`6.2.0-gentoo` on Gentoo VM Guest
* `pve-kernel-6.2.9-1-pve` on PVE VM Host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 6.1.x PVE kernel no longer supported?

Copy link
Contributor Author

@zhtengw zhtengw Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it just means not tested on 6.1 PVE kernel.
Will add more kernel versions in list when tested.

@@ -41,15 +41,15 @@ You can create up to 7 VFs on UHD Graphics 770
4. Move the entire content of the repository to `/usr/src/i915-sriov-dkms-6.1`. The folder name will be the DKMS package name.
5. Execute command `dkms -i -m i915-sriov-dkms -v 6.1`. `-m` argument denotes the package name, and it should be the same as the folder name which contains the package content. `-v` argument denotes the package version, which we have specified in the `dkms.conf` as `6.1`
6. The kernel module should begin building.
7. Once finished, we need to make a few changes to the kernel commandline. `nano /etc/default/grub` and change `GRUB_CMDLINE_LINUX_DEFAULT` to 'intel_iommu=on i915.enable_guc=7`, or add to it if you have other arguments there already.
7. Once finished, we need to make a few changes to the kernel commandline. `nano /etc/default/grub` and change `GRUB_CMDLINE_LINUX_DEFAULT` to 'intel_iommu=on i915.enable_guc=3 i915.max_vfs=7`, or add to it if you have other arguments there already.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be more prominent. People who are upgrading from a previous release of i915-sriov-dkms may not notice this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, may add a note for updating from previous version on the top of README.

Copy link

@FallingSnow FallingSnow Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also do this via by adding a udev rule to /etc/udev/rules.d/intel-sriov.rules if your OS uses udev.

ACTION=="add", DRIVER=="i915", ATTR{sriov_numvfs}="7"

Edit: Never mind, this is a different parameter.

Add notice for updating from previous version.
Add pve-kernel-6.1.0~6.2.9 to tested list.
@strongtz strongtz merged commit cc684d3 into strongtz:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants