Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch more fixes and improvements #200

Merged
merged 5 commits into from
Mar 9, 2022
Merged

A bunch more fixes and improvements #200

merged 5 commits into from
Mar 9, 2022

Conversation

sjaeckel
Copy link
Member

@sjaeckel sjaeckel commented Mar 9, 2022

Major fix

There was a random segfault of the resolver tests in Test-run 5413576855

...
PASS: tests/test_stanza
./test-driver: line 107: [116](https://github.com/strophe/libstrophe/runs/5413576855?check_suite_focus=true#step:5:116)52 Segmentation fault      (core dumped) "$@" > $log_file 2>&1
FAIL: tests/test_resolver
PASS: tests/test_xmppaddr
============================================================================
make[2]: *** [Makefile:2430: test-suite.log] Error 1
Testsuite summary for libstrophe 0.11.0
============================================================================
# TOTAL: 16
# PASS:  15
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to jack@metajack.im
============================================================================
make[2]: Leaving directory '/home/runner/work/libstrophe/libstrophe'
make[1]: *** [Makefile:2538: check-TESTS] Error 2
make: *** [Makefile:2850: check-am] Error 2
make[1]: Leaving directory '/home/runner/work/libstrophe/libstrophe'
Error: Process completed with exit code 2.

Therefor I decided to add fuzzing to the resolver which nearly immediately produced a crash and lead to the bugfix in this PR.

Minor fixes

  • example/perf.c fails to compile on non-supported architectures
  • library fails to build with OpenSSL 1.1.0l on Debian stretch

Improvement

  • show logs in CI

sjaeckel added 3 commits March 9, 2022 12:08
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
In case this ifdef-elseif-chain falls back to the else path, the macro
to `clock()` wasn't defined.

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
based on the "random test" at the end of the regular resolver tests.

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
@sjaeckel sjaeckel requested a review from pasis March 9, 2022 15:06
sjaeckel added 2 commits March 9, 2022 16:48
In case a pointer to itself was received, the resolver looped inifinitely
until the stack overflows.

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
Debian 9.13 (stretch) brings this version and building failed there.

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
@sjaeckel sjaeckel merged commit 528c16e into master Mar 9, 2022
@sjaeckel sjaeckel deleted the more-fixes branch March 9, 2022 15:52
@sjaeckel sjaeckel added this to the 0.12.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant