Stop reaching into X509_ALGOR #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the struct is still public in all versions of OpenSSL and its forks, this may well change in the future. Prepare for that case and use the X509_ALGOR_get0() accessor which has been available with this signature since OpenSSL 1.1.
sjaeckel
approved these changes
Oct 23, 2023
|
On Mon, Oct 23, 2023 at 02:27:53PM -0700, Steffen Jaeckel wrote:
@sjaeckel approved this pull request.
This was already in OpenSSL 1.0.0 and has even been backported to 0.9.8h
Yes, indeed. However, ...
Do you want to update the comment? :)
... the "with this signature" does some work here. There were constness
changes in 1.1.0:
openssl/openssl@ac4e257
|
thanks, I didn't pay attention to the signature change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the struct is still public in all versions of OpenSSL and its forks, this may well change in the future. Prepare for that case and use the X509_ALGOR_get0() accessor which has been available with this signature since OpenSSL 1.1.