-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename heif-convert to heif-dec (planned for v1.18.0) #996
Conversation
Does not seem to work under MSYS2:
I reckon you need to move this inside the examples list, and just after heif-dec is actually installed. |
Makes sense. Better with the above change? |
Better in a sense that it now finds it, but still fails, now with:
|
A web search told me that Windows requires administrator privileges to create symlinks. (The reason is that symlinks were only introduced with Windows Vista and since it would open security risks when using older software, creating symlinks has been restricted to administrators.) Now, what should we do for Windows? Copy the binary instead? |
Traditionally, yes. I though the CMake create_symlink command was actually behaving this way on Windows, and not trying to make a real symlink... |
Another option some software uses, since static (no plugin) builds can be pretty large, is a stub that simply forwards the entire command environment to the real exe, and returns whatever it does. With plug-in being the default, that might be overkill for one scenario. |
@silverbacknet Right, good idea. But in our case, the binary is small (~56 kB). The libheif dll is always separate. It is only the |
@farindk please make sure to change the manpage to reference the new command name (currently still mentions |
CMakeLists.txt
Outdated
@@ -260,6 +260,7 @@ configure_file(libheif.pc.in ${CMAKE_CURRENT_BINARY_DIR}/libheif.pc @ONLY) | |||
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libheif.pc | |||
DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove non-change from diff
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
Renames the executable
heif-convert
toheif-dec
and create a symlink fromheif-convert
toheif-dec
(#985).Could anyone working on Windows and macOS please verify that this works?
Especially generating the symlink with the correct directories and executable suffix (100d172)?