Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #32

Open
wants to merge 11 commits into
base: next
Choose a base branch
from
Open

Windows support #32

wants to merge 11 commits into from

Conversation

ewilh
Copy link

@ewilh ewilh commented Aug 8, 2022

Added Windows support to the project.

Had to remove net472 support and go directly to net6, so I'm not sure if Mac support still works.

@sttz
Copy link
Owner

sttz commented Aug 21, 2022

Cool, thanks for the PR!

Will take a bit of time before I can review and merge this, thanks for your patience.

net472 was there for Homebrew, which only had mono and no proper net5.0/net6.0 support. Now there's a dotnet formula for Homebrew, so I'll hopefully get it working with net6.0, Homebrew and dotnet.

@sttz
Copy link
Owner

sttz commented Sep 5, 2022

Hey, I released v2.11.0 as preparation for the windows support, to remove net472 support and move everything to net6.0.

I've also merged your PR into the windows branch and added some fixes and changes.

Most notably:

  • Default install path is "C:\Program Files". This mirrors behaviour on macOS where Unity is not installed to the same location as Unity Hub does. This is configurable and I'll probably add a section to the readme to explain how to install into the same location as the Hub.
  • Paths that are searched for Unity installations are now configurable, which allows to install the Unity editors in a completely custom location.

Outstanding issues:

  • Privilege elevation does not work for me. Installing or uninstalling Unity results in a "The Requested Operation Requires Elevation" error. It does work when I run the Command Prompt as administrator. Does this work for you?
  • Run does not support detaching. As far as I could gather, this is not possible in C# directly but it should be possible to PInvoke CreateProcess with the CREATE_NEW_PROCESS_GROUP and DETACHED_PROCESS flags.

Feel free to update your PR if you have further changes.

I also appreciate anyone testing the windows branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants