Raw Byte-Array values for Bodies and FormData #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manego
force-pushed
the
am/form-data-improvement
branch
from
30ed8c5
to
17959f9
Compare
zekroTJA
requested changes
Sep 8, 2024
pkg/goatfile/parser.go
Outdated
Comment on lines
820
to
828
| func (t *Parser) parseRawDescriptor() (ast.DataContent, error) { | ||
| tk, varName := t.s.scanString() | ||
| if tk != tokSTRING { | ||
| return ast.NoContent{}, ErrInvalidFileDescriptor | ||
| } | ||
| rd := ast.RawDescriptor{VarName: varName} | ||
|
|
||
| return rd, nil | ||
| } |
There was a problem hiding this comment.
I think, it would make sense to also add the content type specification as same as with file descriptors here.
Example:
[FormData]
image = $uploadedImage:image/png
// or
[Body]
$uploadedImage:image/png
This should be relatively easy by using the same implementation from file descriptors.
There was a problem hiding this comment.
- Added
contentTypetoRawDescriptor - Added parameter substitution for [FormData] values
- Added documentation
zekroTJA
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, the possibility to pass raw byte arrays to the [Body] and the [FormData] blocks was added.
Documentation is still missing and will be written after first Review