-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load picture srcset
from partial
#4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcorieser
changed the title
PoC: Load
PoC: Load picture Mar 24, 2023
srcsets
from partial if providedsrcsets
from partial if provided
Appropriate location for the default definition has to be defined. |
marcorieser
changed the title
PoC: Load picture
Load picture Mar 24, 2023
srcsets
from partial if providedsrcsets
from partial if provided
Nice work. The snippets folder seems fine to me. |
robdekort
requested changes
Mar 24, 2023
And perhaps this is a nice chance to rename |
…set` to `srcset_from` and remove folder structure in `snippets` folder
marcorieser
changed the title
Load picture
Load picture Mar 24, 2023
srcsets
from partial if providedsrcset
from partial if provided
marcorieser
changed the title
Load picture
Load picture Mar 24, 2023
srcset
from partial if providedsrcset
from partial
robdekort
approved these changes
Mar 24, 2023
Since the Maestro Koster has no better approach for overwriting the variable, I'd release it in to the wild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the default picture
srcset
definition is not ideal for a specific case or the whole project. At the moment the only solution would be to alter the picture partial by publishing it but this cuts it off from future updates in the addon.I was wondering if it wouldn't be nice to override the default definition by publishing just the default definition, or to pass a different definition for a specific case.
Due to when / how Antlers evaluates the variables the definition has to be in a partial.
Changes proposed in this pull request:
srcset
definition to a dedicated partialsrcset
variable