-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to deployer 7 #15
Conversation
…ecipes into update-to-deployer-7
@AlanJIsaacson This is ready to test to see if you think it's working reliably. If you think it is, you can approve and merge this pull request & create a new release for v2.0.0 Please note the only thing I cannot reliably get working is Slack notifications.
|
@AlanJIsaacson received an email notification from Slack this morning, which explains why the deployment notifications stopped. I accidentally added it to the deployer recipes GitHub repo so it disabled it for security. That is clever!
Regenerated the webhook URL (see 1Password). |
You can test this on the branch via:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonrjones All tested and double checked with others. I could do with help for the tagging for a new release eg: v2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments based on a few things we previously discussed @AlanJIsaacson which I think would be good to clean up. Thanks.
@@ -0,0 +1,27 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanJIsaacson does this work? If so, can you add a reference to the docs on the installation.md
If not, can you delete this file please - or move to a branch for later testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My memory of our discussions was we were going to avoid using the Deployer recipes and write our own (e.g. like the Craft one) since they seem to take forever to update releases. I did commit that fix to the Craft recipe in Deployer but it's still not been released sadly.
- Creating example deploy files for each platform we use - Doc updates - Normalise task names
- Update install, upgrade, slack docs - Use default paths for Mythic Beasts in example deploy.php files - Add tests to make logs more robust when expanding wildcards
Update to use Deployer 7, ready for testing.
@AlanJIsaacson This is ready to test to see if you think it's working reliably.
If you think it is, you can approve and merge this pull request & create a new release for v2.0.0
Please note the only thing I cannot reliably get working is Slack notifications.