Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to deployer 7 #15

Merged
merged 49 commits into from
May 7, 2024
Merged

Update to deployer 7 #15

merged 49 commits into from
May 7, 2024

Conversation

simonrjones
Copy link
Member

@simonrjones simonrjones commented Dec 20, 2022

Update to use Deployer 7, ready for testing.

@AlanJIsaacson This is ready to test to see if you think it's working reliably.

If you think it is, you can approve and merge this pull request & create a new release for v2.0.0

Please note the only thing I cannot reliably get working is Slack notifications.

@simonrjones
Copy link
Member Author

@AlanJIsaacson This is ready to test to see if you think it's working reliably.

If you think it is, you can approve and merge this pull request & create a new release for v2.0.0

Please note the only thing I cannot reliably get working is Slack notifications.

@simonrjones
Copy link
Member Author

simonrjones commented Apr 3, 2023

@AlanJIsaacson received an email notification from Slack this morning, which explains why the deployment notifications stopped. I accidentally added it to the deployer recipes GitHub repo so it disabled it for security. That is clever!

We recently discovered a publicly accessible incoming webhook associated with the Deployer app installed on your studio24.slack.com workspace. This can happen when someone who created or has access to a webhook URL posts it on a public site, such as Github or other code-sharing forums. None of your data is at risk — webhooks can only send messages into Slack and cannot access any data.

Regenerated the webhook URL (see 1Password).

@simonrjones
Copy link
Member Author

See Slack notifications usage

@simonrjones
Copy link
Member Author

You can test this on the branch via:

composer require studio24/deployer-recipes:dev-update-to-deployer-7 --dev

Copy link
Member

@AlanJIsaacson AlanJIsaacson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonrjones All tested and double checked with others. I could do with help for the tagging for a new release eg: v2.0.0

Copy link
Member Author

@simonrjones simonrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments based on a few things we previously discussed @AlanJIsaacson which I think would be good to clean up. Thanks.

examples/deploy.php Outdated Show resolved Hide resolved
recipe/craftcms.php Show resolved Hide resolved
recipe/craftcms.php Show resolved Hide resolved
recipe/craftcms.php Outdated Show resolved Hide resolved
recipe/craftcms.php Outdated Show resolved Hide resolved
recipe/craftcms.php Outdated Show resolved Hide resolved
@@ -0,0 +1,27 @@
<?php
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanJIsaacson does this work? If so, can you add a reference to the docs on the installation.md

If not, can you delete this file please - or move to a branch for later testing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory of our discussions was we were going to avoid using the Deployer recipes and write our own (e.g. like the Craft one) since they seem to take forever to update releases. I did commit that fix to the Craft recipe in Deployer but it's still not been released sadly.

recipe/craftcms.php Outdated Show resolved Hide resolved
recipe/craftcms.php Outdated Show resolved Hide resolved
@simonrjones simonrjones merged commit a86dbbb into main May 7, 2024
4 checks passed
@simonrjones simonrjones deleted the update-to-deployer-7 branch May 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants