Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Do not attempt to inline Font Awesome CSS in the editor #297

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Do not attempt to inline Font Awesome CSS in the editor #297

merged 1 commit into from
Feb 10, 2020

Conversation

nickcernis
Copy link
Collaborator

@nickcernis nickcernis commented Feb 5, 2020 •
edited
Loading

Fixes the issue noted in #127 and introduced in #294, where icons in existing AB Sharing blocks will fail to load in the editor if REST requests return rendered page content that contains an AB Sharing block.

Have the changes in this PR been added to the documentation for this project?
No docs required.

How to test:

  1. Add an AB Sharing block to a new page.
  2. Confirm that:
    • Icons appear in the editor when first adding the block.
    • Icons still appear in the editor when saving the page and refreshing.
    • Icons appear on the front end.
    • Pages without the AB Sharing block do not load the 'all.css' Font Awesome stylesheet.

Suggested Changelog Entry:
Fix an issue where AB Sharing block icons could fail to load in the editor.

Notes:
This is branched from master and targets master since it's a patch. Happy to rebase on develop if needed, though.

@nickcernis
Do not attempt to inline fontawesome CSS in the editor
5b3dfe9 
Fixes the issue noted in #127 and introduced in #294, where icons
in existing AB Sharing blocks will fail to load in the editor if REST
requests return other pages that have an AB Sharing block.
@nickcernis nickcernis mentioned this pull request Feb 5, 2020
Closed
mindctrl
mindctrl approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@mindctrl mindctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks for the PR @nickcernis!

mikemcalister
mikemcalister approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@mikemcalister mikemcalister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly over here. Thanks, @nickcernis!

mindctrl added a commit that referenced this pull request Feb 10, 2020
@mindctrl
Merge branch 'fix/fontawesome-admin'. PR #297. Closes #127. Fixes bug…
f68673f 
… introduced in #294.
@mindctrl mindctrl merged commit 5b3dfe9 into master Feb 10, 2020
mindctrl added a commit that referenced this pull request Feb 10, 2020
@mindctrl
Merge branch 'fix/fontawesome-admin' into develop. PR #297. Closes #127…
58a4c4f 
…. Fixes bug introduced in #294.
@mindctrl mindctrl deleted the fix/fontawesome-admin branch February 10, 2020 19:58
@westonruter westonruter mentioned this pull request Jun 15, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikemcalister mikemcalister mikemcalister approved these changes

@mindctrl mindctrl mindctrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickcernis @mindctrl @mikemcalister