fix: use gulp-umd instead of buggy globalize #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `globalize.js` file used to export to various module loader environments had some buggy behavior in it, making it incompatible with Webpack in next.js. This replaces the hardcoded `globalize.js` and IIFE wrapper with the standardized UMD wrapper, provided by the `gulp-umd` plugin. There is no change in functionality, except that for isomorphic apps, Pressure.js will load, but all its methods will be no-ops.
|
@zetlen wow this is awesome 🙌! Really great stuff in here, that UMD package is definitely a big improvement and makes the compilation less fragile so thank you for that! I will update this later tonight! Thanks so much again! |
|
@zetlen just deployed this as v2.0.2, thanks for the contribution! Greatly appreciated. https://github.com/stuyam/pressure/releases/tag/v2.0.2 |
|
Hey, I'm sorry it took me a while to respond to this--work has been hectic. Sorry I forgot to remote the old dep, that was sloppy of me. I see you've taken care of it. Hey, your library is great. I really appreciate you doing the work to normalize this into a clean API. You can see it in action, in my own little way, on my personal website: https://zetlen.github.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
globalize.jsfile used to export to various module loader environments had some buggy behavior in it, making it incompatible with Webpack in next.js. This replaces the hardcodedglobalize.jsand IIFE wrapper with the standardized UMD wrapper, provided by thegulp-umdplugin.
There is no change in functionality, except that for isomorphic apps, Pressure.js will load, but all its methods will be no-ops.