Created Borders and Aligned Recruitments Page #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leomet07
approved these changes
Nov 6, 2023
|
Hey Amaryllis (@amaryllis-sun )! Nice job on making this pull request! I really liked the addition of the borders and raising the line spacing. My only comments is to make sure to use the accent color (with Other than that, thanks for your work! Check out your contributions on stuyspec.com, they're already live! Make sure to rebase and maintain your fork now! (See the "Next Steps" section at the end of the instructions sent out!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all the information for the departments was directly next to each other, I added borders around each department along with some padding to help viewers distinguish the information as well as make it easier to digest. Furthermore, I just added some smaller styling stuff (e.g. colors and rounded borders) to make it more visually appealing and stand out on the website.