Fix toHaveStyleRule support classes with displayName prefix #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@probablyup any chance to look on this, please 🙏? It blocks us in updating |
quantizor
reviewed
Mar 17, 2020
src/toHaveStyleRule.js
Outdated
| @@ -68,7 +68,7 @@ const getModifiedClassName = (className, staticClassName, modifier = "") => { | |||
| }; | |||
|
|
|||
| const hasClassNames = (classNames, selectors, options) => { | |||
| const staticClassNames = classNames.filter(x => x.startsWith("sc-")); | |||
| const staticClassNames = classNames.filter(x => /^(\w+-)?sc-\w+/.test(x)); | |||
There was a problem hiding this comment.
I don't think we want the \w+ part at the end
|
@vxcamiloxv Could you add a test or two? ty |
|
@probablyup sure |
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
toHaveStyleRulesupport for classes with adisplayNameprefix from babel-plugin-styled-componentsCloses #290 #294