Skip to content
This repository has been archived by the owner on Jun 30, 2024. It is now read-only.

Support function calls #237

Merged
merged 4 commits into from
Oct 11, 2020

Conversation

umanghome
Copy link
Contributor

@umanghome umanghome commented Oct 10, 2020

Before:
image

After:
image

This will break if the function call spans multiple lines as TextMate Grammar can only match single lines. microsoft/vscode-textmate#32

I'm not very familiar with TextMate Grammars. This might not even be the correct way to solve the problem of function calls.

.nvmrc Show resolved Hide resolved
@jasonwilliams jasonwilliams merged commit 7fa4048 into styled-components:master Oct 11, 2020
@jasonwilliams
Copy link
Collaborator

Thanks for the contribution @umanghome hopefully you can help on other issues too!

@jasonwilliams
Copy link
Collaborator

@umanghome was there an issue this was tied to?

@umanghome
Copy link
Contributor Author

Not for function calls. I was trying to fix #233 and function calls together.

@jasonwilliams
Copy link
Collaborator

@umanghome are you still working on #233 then?

@umanghome
Copy link
Contributor Author

#233 can't be fixed as function declarations usually span multiple lines and TextMate Grammar doesn't support matching multiple lines. microsoft/vscode-textmate#32

I'll comment this on the issue and the one linked to it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants