-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong union description with TypeScript #1621
Comments
You can hover your mouse over the field for a few seconds to see the actual value, but I can understand the fact that more people don't realize it. So... we can change this, but first, we need to decide what kind of UI we want.
FYI @sapegin what do you think? |
Yeah, I know that I can hover on Pic. 2 is fine I guess. Union description could be quite long, so putting it in type column may look sloppy. |
I think unions can be very very long, and improving tooltips could be a better solution in general — showing a nice HTML tooltip where we can format code on multiple lines, instead of a |
This looks good! A couple of comments:
|
sounds good! |
Nope, but I'd prefer a library if it won't bring too many dependencies (like another CSS in JS library ;-) and it must be accessible with a keyboard and a screen reader. |
🎉 This issue has been resolved in version 11.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Current behavior
When using TypeScript unions, react-styleguidist isn't providing any description. Moreover, is shows annoying empty div.
To reproduce
Use TypeScript and add description to any union field. Demo: https://codesandbox.io/s/goofy-forest-zmeiy
Expected behavior
Unwrapped union description or at least no empty div.
Version
11.0.8
The text was updated successfully, but these errors were encountered: