Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot onClick handler calls previous slot's onClick #971

Closed
kidkuro opened this issue May 8, 2018 · 1 comment · Fixed by #972
Closed

Slot onClick handler calls previous slot's onClick #971

kidkuro opened this issue May 8, 2018 · 1 comment · Fixed by #972
Labels
help wanted

Comments

@kidkuro
Copy link
Contributor

kidkuro commented May 8, 2018

There's a small coding bug in Slot.js where props is reassigned in a loop, so the onClick handler of all slots after the first end up delegating back to the first slot's onClick.

It's hard to produce a demo for this, it's more future proofing for custom slots. I'll create a PR with a unit test.
kidkuro pushed a commit to kidkuro/react-styleguidist that referenced this issue May 9, 2018
Fix: Slot onClick passes correct id (styleguidist#971)
fcddda2
@kidkuro kidkuro mentioned this issue May 9, 2018
Merged
sapegin pushed a commit that referenced this issue May 15, 2018
@kidkuro @sapegin
Fix: Slot onClick passes correct ID (#972)
f5b0057 
Fixes #971
@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 7.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Yoasia1985 Yoasia1985 mentioned this issue Jul 7, 2023
Open
@kopax kopax mentioned this issue Jul 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Slot onClick passes correct id kidkuro/react-styleguidist
3 participants
@sapegin @kidkuro @styleguidist-bot